Project

General

Profile

Actions

Feature #420

open

Use standard format of TPM event log

Added by Krystian Hebel about 2 years ago. Updated 2 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
10/12/2022
Due date:
% Done:

33%

Estimated time:
(Total: 0.00 h)
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

Currently coreboot uses proprietary format for TPM event log. TCG has standardized log formats, differently for TPM1.2 (aka legacy or SHA1) [1] and TPM2.0 (aka crypto agile) [2], both of which can be parsed by Linux kernel and exposed in sysfs. I don't know of any tool outside of cbmem which can parse coreboot format; this includes payloads which may be interested in continuing chain of trust started by coreboot.

Another incompatibility is caused by vboot's assignment of PCRs. Roles of PCRs are roughly specified by TCG in both of mentioned documents, they are more or less compatible with each other, but not with current coreboot code.

These changes could break assumptions made by existing platforms, so they should be made as Kconfig options.

This is a tracking issue to collect subtasks that need to be done in order to support standard event log formats.


Subtasks 6 (4 open2 closed)

Cleanup #421: Change API of functions taking hash as an argumentNew10/12/2022

Actions
Feature #422: Create Kconfig menu for TPM event log formatNew10/12/2022

Actions
Feature #423: Implement legacy and crypto agile TPM event log formatsNew10/12/2022

Actions
Feature #424: Create and implement option to choose either TCG or vboot PCR assignmentNew10/12/2022

Actions
Feature #425: Add parsing of new TPM event log formats to cbmem utilityResolved10/12/2022

Actions
Documentation #426: Document existing and added TPM event log formats and PCR usageResolved10/12/2022

Actions
Actions #1

Updated by Krystian Hebel about 2 years ago

  • Related links updated (diff)
Actions #2

Updated by Arthur Heymans almost 2 years ago

https://review.coreboot.org/c/coreboot/+/51710 Implements the TCG one. The coreboot implementation is not a 'proprietary' format. That would imply that there is a license restriction on using it which there is not.
A lot of the TCG spec simply does not make a lot of sense for coreboot which is why it's not implemented.

Actions #3

Updated by Michał Żygowski almost 2 years ago

  • Related links updated (diff)

Arthur Heymans wrote in #note-2:

https://review.coreboot.org/c/coreboot/+/51710 Implements the TCG one. The coreboot implementation is not a 'proprietary' format. That would imply that there is a license restriction on using it which there is not.
A lot of the TCG spec simply does not make a lot of sense for coreboot which is why it's not implemented.

Yes, it is not "proprietary", "custom" would be a better word here. Anyway, having an option for TCG compliant event log will not hurt.

Thank you for pointing the patch, adding to Related Links.

Actions #4

Updated by Michał Żygowski almost 2 years ago

  • Related to Cleanup #421: Change API of functions taking hash as an argument added
Actions #5

Updated by Michał Żygowski almost 2 years ago

  • Related to Feature #422: Create Kconfig menu for TPM event log format added
Actions #6

Updated by Michał Żygowski almost 2 years ago

  • Related to Feature #423: Implement legacy and crypto agile TPM event log formats added
Actions #7

Updated by Michał Żygowski almost 2 years ago

  • Related to Feature #424: Create and implement option to choose either TCG or vboot PCR assignment added
Actions #8

Updated by Michał Żygowski almost 2 years ago

  • Related to Feature #425: Add parsing of new TPM event log formats to cbmem utility added
Actions #9

Updated by Michał Żygowski almost 2 years ago

  • Related to Documentation #426: Document existing and added TPM event log formats and PCR usage added
Actions #10

Updated by Michał Żygowski almost 2 years ago

Adding subtask seems to be a new issue creation. In order to avoid duplication, I have added these issues from related links to the Related Issues section.

Actions #11

Updated by Michał Żygowski almost 2 years ago

  • Related links updated (diff)

Michał Żygowski wrote in #note-10:

Adding subtask seems to be a new issue creation. In order to avoid duplication, I have added these issues from related links to the Related Issues section.

NVM, I can assign Parent Task to the other issues and it will automatically link as subtask.

Actions #12

Updated by Sergii Dmytruk 2 months ago

2 out of 6 subtasks are closed, but really all of them are done by now, including this one.

Actions

Also available in: Atom PDF