I put together a PoC if anyone wants to work on this: https://review.coreboot.org/c/flashrom/+/84102 ([demonstration](https://github.com/linuxboot/heads/pull/1753#issuecomment-2312867681)). I think the progress is very useful to have, b...Sergii Dmytruk
> Add an option to compile all drivers for TPM 1.2, 2.0 TIS and CRB. An option like "compile all of them" or just allow selecting any subset of the drivers?Sergii Dmytruk
Julius Werner wrote in #note-10: > I still feel strongly that we shouldn't overcomplicate APIs It would actually simplify the API by making parameter lists shorter and input data better grouped. > ... `skiboot` writes both SHA1 an...Sergii Dmytruk
Julius Werner wrote in #note-8: > are you planning to make a bunch of Kconfigs to select this vboot2 supports 4 matching hashes, so 4 corresponding options. > ... This approach will require returning to these changes, understandin...Sergii Dmytruk
Sergii Dmytruk wrote in #note-5: > `tpm_extend_pcr()` would be updated for consistency here, but it's not strictly necessary. Correction: `tpm_extend_pcr()` can invoke `tcpa_log_add_table_entry()` in its body, so it should have a sim...Sergii Dmytruk
> Can you explain what use case you have that requires you to use multiple algorithms? I'll let Krystian and MichaĆ correct me, but I'm not sure if we have an actual need for multiple algorithms right away. The API change is probably...Sergii Dmytruk
If there are no objections, I'll use an API like this instead: ``` struct tpm_digest { const uint8_t *hash; size_t len; enum vb2_hash_algorithm hash_type; }; /** * Ask vboot for a digest and extend a TPM PCR with it. * ...Sergii Dmytruk