Bug #256
closed
X201: Not probing for dock on wakeup
Added by Stefan Ott about 4 years ago.
Updated almost 3 years ago.
Description
With stock BIOS and older versions of coreboot (4.9-7f520c8f), the Thinkpad X201 re-attaches itself to the docking station if it was docked while suspended; with the current master (and 4.11 release) this does not work anymore, i.e. it only detects the dock if the docking event occurs while the machine is awake.
Files
Please attach the logs cbmem -1 with the old-working and regressed coreboot versions.
I believe your issue has the higher chances to be fixed, if you bisect the commit causing the regression (git bisect).
Paul Menzel wrote:
Please attach the logs cbmem -1 with the old-working and regressed coreboot versions.
I believe your issue has the higher chances to be fixed, if you bisect the commit causing the regression (git bisect).
I did some debugging with cbmem and noticed that coreboot does detect the dock (it says "dock is connected") on resume, it just seems to fail to tell the OS about it; the logs are attached.
Here we go, I made a bunch of logs. For coreboot 4.9 (works) and 4.11 (does not work) I took a cbmem -1 log after bootup (docked), wakeup (docked) and after a docking procedure (while awake).
I found the commit that broke it with git bisect, it appears to be 72f13e5 ("Make dock init in ramstage fully mainboard-specific").
And indeed, if I revert that commit, it works. I'll attach a crude patch to show what I had to change.
- Status changed from New to Resolved
- % Done changed from 0 to 100
Also available in: Atom
PDF