Bug #256: X201: Not probing for dock on wakeup - coreboot - Issue Tracker

Actions

Copy link

Bug #256

closed

X201: Not probing for dock on wakeup

Added by Stefan Ott almost 5 years ago. Updated over 3 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Category:

Target version:

Start date:

03/19/2020

Due date:

% Done:

100%

Estimated time:

Affected versions:

Needs backport to:

Affected hardware:

Affected OS:

Description

With stock BIOS and older versions of coreboot (4.9-7f520c8f), the Thinkpad X201 re-attaches itself to the docking station if it was docked while suspended; with the current master (and 4.11 release) this does not work anymore, i.e. it only detects the dock if the docking event occurs while the machine is awake.

Files

Download all files

coreboot-4.9-powerup.log (6.98 KB) coreboot-4.9-powerup.log		Stefan Ott, 03/19/2020 05:59 PM
coreboot-4.9-redock.log (2.75 KB) coreboot-4.9-redock.log		Stefan Ott, 03/19/2020 05:59 PM
coreboot-4.9-wakeup.log (2.75 KB) coreboot-4.9-wakeup.log		Stefan Ott, 03/19/2020 05:59 PM
coreboot-4.11-powerup.log (27.1 KB) coreboot-4.11-powerup.log		Stefan Ott, 03/19/2020 05:59 PM
coreboot-4.11-redock.log (17.5 KB) coreboot-4.11-redock.log		Stefan Ott, 03/19/2020 05:59 PM
coreboot-4.11-wakeup.log (17.5 KB) coreboot-4.11-wakeup.log		Stefan Ott, 03/19/2020 05:59 PM
coreboot-x201-dock-attach.patch (1.96 KB) coreboot-x201-dock-attach.patch		Stefan Ott, 03/20/2020 12:44 PM

Actions

Copy link

Updated by Paul Menzel almost 5 years ago

Please attach the logs cbmem -1 with the old-working and regressed coreboot versions.

I believe your issue has the higher chances to be fixed, if you bisect the commit causing the regression (git bisect).

Actions

Copy link

Updated by Stefan Ott almost 5 years ago

Paul Menzel wrote:

Please attach the logs cbmem -1 with the old-working and regressed coreboot versions.

I believe your issue has the higher chances to be fixed, if you bisect the commit causing the regression (git bisect).

I did some debugging with cbmem and noticed that coreboot does detect the dock (it says "dock is connected") on resume, it just seems to fail to tell the OS about it; the logs are attached.

Actions

Copy link Download all files

Updated by Stefan Ott almost 5 years ago

File coreboot-4.9-powerup.log coreboot-4.9-powerup.log added
File coreboot-4.9-redock.log coreboot-4.9-redock.log added
File coreboot-4.9-wakeup.log coreboot-4.9-wakeup.log added
File coreboot-4.11-powerup.log coreboot-4.11-powerup.log added
File coreboot-4.11-redock.log coreboot-4.11-redock.log added
File coreboot-4.11-wakeup.log coreboot-4.11-wakeup.log added

Here we go, I made a bunch of logs. For coreboot 4.9 (works) and 4.11 (does not work) I took a cbmem -1 log after bootup (docked), wakeup (docked) and after a docking procedure (while awake).

Actions

Copy link