If we want to do major changes to the TPM API I would prefer to use that opportunity to rather redesign it from scratch instead of perpetuating a bunch of weird design choices that haven't made sense in a while (or ever, really). A lot o...Julius Werner
> However, instead of following existing standards, be it TCG or coreboot, such approach creates yet another one. Having the ability to use more than one would make transition to TPM2.0 easier, if not no-op. Since we are going to have to...Julius Werner
> It would actually simplify the API by making parameter lists shorter and input data better grouped. Having to construct a separate parameter struct rather than just throwing in two scalars is not "simpler". > ... I don't know wha...Julius Werner
> I think we might as well implement agile format properly (no fixed-size buffers in structures, any number of algorithms) right away. You are implementing the format properly (the format defines how the TCPA log is supposed to look i...Julius Werner
> > Can you explain what use case you have that requires you to use multiple algorithms? > ... Sorry, but that sounds kinda vague... I mean, do you actually have a case right now where you need this on one of the coreboot platforms you'...Julius Werner
Can you explain what use case you have that requires you to use multiple algorithms? And why is it not enough to just call tpm_extend_pcr() several times, once for each algorithm? Let's clarify what your high-level goal here is first ...Julius Werner
Chromebooks never use BootGuard, so the firmware on those devices should be fully replaceable and they should support all the usual Chromebook developer features (e.g. https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/H...Julius Werner
Some more digging, it's probably this: https://bugs.chromium.org/p/gerrit/issues/detail?id=10658 Looks like it was fixed but we'll need to wait for the next release.Julius Werner
It seems that something broke with Gerrit's syntax highlighting recently (probably as part of some update?). Function parameters are colored in orange and in a way that suggests they're not getting parsed correctly (e.g. mismatched brace...Julius Werner
> Right now the jenkins job that returns warnings only runs (and therefore returns) the checkpatch script. I guess we'll have to extend it to run kconfig_lint, too? Oh, really? I could've sworn I had seen this before, that's the whole...Julius Werner