Feature #202

Some kconfig_lint warnings don't get posted to Gerrit

Added by Julius Werner 2 months ago. Updated 2 months ago.

Status:NewStart date:04/05/2019
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:infrastructure
Target version:-

Description

https://review.coreboot.org/c/coreboot/+/31776 added some new kconfig_lint warnings related to the CONFIG() macro. The intention was that these would get posted as comments to Gerrit to alert developers, but that somehow doesn't seem to happen (e.g. here https://review.coreboot.org/c/coreboot/+/29917/30/src/cpu/amd/family_10h-family_15h/init_cpus.c#1061). If I run the linter locally I can see the warning show up with the right file and line number. I assume this is a bug with the code that parses linter output and generates Gerrit comments out of them? I don't know where that lives, it doesn't seem to be in the tree.

History

#1 Updated by Patrick Georgi 2 months ago

  • Tracker changed from Bug to Feature

Right now the jenkins job that returns warnings only runs (and therefore returns) the checkpatch script. I guess we'll have to extend it to run kconfig_lint, too?

#2 Updated by Julius Werner 2 months ago

Right now the jenkins job that returns warnings only runs (and therefore returns) the checkpatch script. I guess we'll have to extend it to run kconfig_lint, too?

Oh, really? I could've sworn I had seen this before, that's the whole reason I added those warnings there. Maybe I confused it with the actual kconfig_lint errors that block Verified+1.

I think adding it would be neat, especially for warnings like "unused symbol", "unknown config option" or "naked reference to CONFIG_xxx" (where there are so many in the tree right now that it wouldn't be easy to clean them up, but new additions are still very likely to be mistakes). But alternatively we can also turn a few more into full errors (at least "CONFIG() used on unknown value", since that seems to be a common mistake and cleaning up false positives wasn't too disruptive).

Also available in: Atom PDF