Project

General

Profile

Actions

Bug #205

closed

Broken Gerrit syntax highlighting

Added by Julius Werner over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
infrastructure
Target version:
-
Start date:
04/30/2019
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

It seems that something broke with Gerrit's syntax highlighting recently (probably as part of some update?). Function parameters are colored in orange and in a way that suggests they're not getting parsed correctly (e.g. mismatched braces). Example screenshot attached. This can be seen in pretty much all code that has functions with parameters (e.g. https://review.coreboot.org/c/coreboot/+/32288/3/src/soc/qualcomm/common/qclib.c#41 ).


Files

gerrit_syntax_fail.png (59.2 KB) gerrit_syntax_fail.png Julius Werner, 04/30/2019 12:41 AM
Actions #1

Updated by Julius Werner over 5 years ago

Some more digging, it's probably this: https://bugs.chromium.org/p/gerrit/issues/detail?id=10658

Looks like it was fixed but we'll need to wait for the next release.

Actions #2

Updated by Patrick Georgi over 5 years ago

  • Status changed from New to Resolved

Just installed 2.16.8 and the syntax highlighting looks good here (although it's much less colorful)

Actions

Also available in: Atom PDF