Project

General

Profile

Actions
Copy link

Feature #375

closed

Check the right chipset is selected for Intel Emmitsburg PCH

Added by Anastasia Klimchuk over 2 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
David Hendricks
Category:
Release prep
Target version:
-
Start date:
04/28/2022
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Files

ebg_7228ce0_read.txt (9.03 KB) ebg_7228ce0_read.txt David Hendricks, 05/08/2022 09:10 PM

Related links

https://review.coreboot.org/c/flashrom/+/54965

Actions
Copy link
 #1

Updated by Edward . over 2 years ago

  • Assignee set to David Hendricks

Hey David, could you take a look into this please?

Actions
Copy link
 #2

Updated by David Hendricks over 2 years ago

Edward . wrote in #note-1:

Hey David, could you take a look into this please?

Yes, the right chipset is selected. I also verified this result on a CRB w/ Emmitsburg just now using the master branch (verbose output attached). 1.3.x will need to cherry-pick 51e1d0e and 106f097 from master, at least.

Actions
Copy link
 #3

Updated by Nico Huber over 2 years ago

What was mentioned in the review already, compared to Lewisburg:

  • The missing FREG registers were added.
  • Software sequencing is not allowed anymore (so should we disabled it by default even if we are not locked out?)

Also:

  • FLCOMP in the descriptor got an update, e.g. the printed frequencies are off.

I guess it generally got the same update as other newer chipsets.

If nobody cares about the informational output for a given chipset, should we disable it selectively?

Actions
Copy link
 #4

Updated by Felix Singer about 2 years ago

  • Status changed from New to Response Needed

We are not entirely sure what's left to do here. Is it release blocking?

Actions
Copy link
 #5

Updated by Anastasia Klimchuk over 1 year ago

  • Target version deleted (1.3)
  • Parent task deleted (#353)
Actions
Copy link
 #6

Updated by Anastasia Klimchuk 6 months ago

  • Status changed from Response Needed to Closed
Actions
Copy link

Also available in: Atom PDF