flashrom

After the discussion on the meeting, some answers to initial questions:
1) Yes, and this is WAI because these chips are copy-pasta of Winbond
3) This is correct.

Remaining question need to be answered is 2) which means checking the datasheets and compare with chip definitions for block erasers.

2) I have checked the erasers, they are all correct and none are missing.

On #3, the smaller variants of the chip (<256Mbit) do not support 4BA_WRITE, however the XM25Qx256C chips do appear to. They do also work in a "backwards compatible" mode that doesn't require the 4-byte addressing (see section "5.1.5 3-Byte/4-Byte Address Modes" of the datasheet), so they can work without 4BA_WRITE beings set as well.

Looks like this is resolved, can be closed. Let me double-check.

I understand most of the chip definitions are correct. Is anything left to do on the chip definitions for XM25QH256C and XM25QU256C regarding the 4BA mode?

I will add the FEATURE_4BA_WRITE flag for these chips.