Refactoring #360
closed
Feature #353: Release v1.3
Document and clean up parade_lspcon.c programmer
Added by Anastasia Klimchuk about 2 years ago.
Updated over 1 year ago.
Description
Man page entry done
We can also try to add more info for developers, see if code can be commented better?
Some specific questions:
1) Too generic name: LSPCon is a concept but driver seems to be about a specific vendor/chip.
2) No probing just starts to write to hardcoded addresses.
3) WP code contains magic numbers, board specific?
4) Implements spi_master but contains hard-coded SPI opcodes.
- Description updated (diff)
Items TODO from the discussion:
1) update lspcon_i2c_spi_write_aai documentation, why it throws an error straight away, why it is not using default aai function.
2) implement allow_brick parameter, tracked here https://ticket.coreboot.org/issues/395
3) add documentation at the top of the file that only very specific chips supported. Document as much as you can on the top. When it is working and when it is not working.
4) opaque master? https://ticket.coreboot.org/issues/398
- Status changed from New to In Progress
- Tracker changed from Documentation to Feature
- Subject changed from Document lspcon_i2c_spi.c programmer to Document and clean up parade_lspcon.c programmer
- Status changed from In Progress to Resolved
After series of patches on this programmer, all the work done and the ticket is resolved. The programmer got renamed in the process.
- Tracker changed from Feature to Refactoring
- % Done changed from 0 to 100
Also available in: Atom
PDF