Bug #15

board-status uploads incorrect reports if config not found

Added by Timothy Pearson over 3 years ago. Updated over 3 years ago.

Status:In ProgressStart date:12/01/2015
Priority:NormalDue date:12/02/2015
Assignee:Patrick Georgi% Done:

0%

Category:infrastructure
Target version:-

Description

The board-status script uploads reports for a nonexistent mainboard if the coreboot configuration file is not found in CBFS. It should abort the upload if the CBFS configuration file access fails.

Script output during failure:
~~~
E: File not found: config
mv: cannot stat ‘/tmp/coreboot_board_status.i4CRMqXl/config.txt’: No such file or directory
cp: cannot stat ‘/tmp/coreboot_board_status.i4CRMqXl/config.short.txt’: No such file or directory
~~~

Example of failed/incorrect board-status commit:
https://review.coreboot.org/gitweb?p=board-status.git;a=commit;h=d4370d70b721b964ed47df422935c01e6c887bff

Example of correct board-status commit:
https://review.coreboot.org/gitweb?p=board-status.git;a=commit;h=a633af9397e42af0b436e2f75417aca71b056c4a

CBFS contents causing the problem:
https://review.coreboot.org/gitweb?p=board-status.git;a=blob;f=emulation/qemu-armv7/4.2-441-g1a38374/2015-12-01T15:59:41Z/cbfs.txt;h=0839a112bc295e16a4624acb33c73bf3fa9ba9d0;hb=d4370d70b721b964ed47df422935c01e6c887bff

Correct CBFS contents:
https://review.coreboot.org/gitweb?p=board-status.git;a=blob;f=asus/kfsn4-dre/4.2-413-g8528e39/2015-11-28T18:21:18Z/cbfs.txt;h=a633af9397e42af0b436e2f75417aca71b056c4a;hb=2b0d3777959841375d6ca1cf5164ec9d3f8a235d

History

#1 Updated by Patrick Georgi over 3 years ago

  • Status changed from New to Resolved
  • Due date set to 12/02/2015

#2 Updated by Aaron Durbin over 3 years ago

  • Status changed from Resolved to In Progress

#3 Updated by Timothy Pearson over 3 years ago

The board-status script itself should be modified to detect the missing CBFS files and abort upload.

Also available in: Atom PDF