Bug #15
openboard-status uploads incorrect reports if config not found
0%
Description
The board-status script uploads reports for a nonexistent mainboard if the coreboot configuration file is not found in CBFS. It should abort the upload if the CBFS configuration file access fails.
Script output during failure:
E: File not found: config
mv: cannot stat ‘/tmp/coreboot_board_status.i4CRMqXl/config.txt’: No such file or directory
cp: cannot stat ‘/tmp/coreboot_board_status.i4CRMqXl/config.short.txt’: No such file or directory
Example of failed/incorrect board-status commit:
https://review.coreboot.org/gitweb?p=board-status.git;a=commit;h=d4370d70b721b964ed47df422935c01e6c887bff
Example of correct board-status commit:
https://review.coreboot.org/gitweb?p=board-status.git;a=commit;h=a633af9397e42af0b436e2f75417aca71b056c4a
CBFS contents causing the problem:
https://review.coreboot.org/gitweb?p=board-status.git;a=blob;f=emulation/qemu-armv7/4.2-441-g1a38374/2015-12-01T15:59:41Z/cbfs.txt;h=0839a112bc295e16a4624acb33c73bf3fa9ba9d0;hb=d4370d70b721b964ed47df422935c01e6c887bff
Updated by Patrick Georgi almost 9 years ago
- Due date set to 12/02/2015
- Status changed from New to Resolved
Fixed by https://review.coreboot.org/12581
Updated by Aaron Durbin almost 9 years ago
- Status changed from Resolved to In Progress
Updated by Timothy Pearson almost 9 years ago
The board-status script itself should be modified to detect the missing CBFS files and abort upload.
Updated by Patrick Georgi over 4 years ago
- Blocks Feature #210: Improve board-status added