Issue Tracker

10/08/2020

AD 09:00 PM coreboot Bug #281: cbfs stage loading||encoding is not endian safe.

https://review.coreboot.org/c/coreboot/+/46227 Aaron Durbin

AD 03:40 PM coreboot Bug #281: cbfs stage loading||encoding is not endian safe.

I agree that this should be corrected, but there's not much we can do while still maintaining backwards compatibility. The endian calls, regardless of which one employed, would be required. The thing that always bugs me is the inconsiste... Aaron Durbin

10/07/2020

AD 05:15 PM coreboot Bug #281: cbfs stage loading||encoding is not endian safe.

Thanks for the info. In the end it doesn't matter...
https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/util/cbfstool/cbfs-mkstage.c#80
`
>-------/* N.B. The original plan was that SELF data was B.E.
> ...
`... Aaron Durbin

AD 04:56 PM coreboot Bug #281: cbfs stage loading||encoding is not endian safe.

Original sighting:
"fsize of 0x5c32_0000 and a stage.len of 0x0000_325c"
Update #3:
"fsize: 0x0000_313c stage.len: 0x3c31_0000"
Those are in conflict. From the hexdump I can see cbfs_file is correct for romstage. And given update... Aaron Durbin

AD 02:49 PM coreboot Bug #281: cbfs stage loading||encoding is not endian safe.

fsize is derived from the region_device size for the data in cbfs_for_each_file():
~~~
file.len = read_be32(&file.len);
file.offset = read_be32(&file.offset);
~~~
Those fields are expected to be big endian. There's a comment in ... Aaron Durbin

07/01/2019

AD 08:59 PM coreboot Bug #217 (New): spi flash cleanup

We should clean up the specialized spi flash controllers which is leading to buffer inspection and work arounds in data structures.
See this commentary: https://review.coreboot.org/c/coreboot/+/33821/8/src/drivers/spi/spi_flash.c#103 Aaron Durbin

05/09/2018

AD 06:38 PM coreboot Bug #166: UEFI MP Services

When I wrote 'for mp_init currently' I meant use mp_init as the implementation for the UEFI PPI callbacks. Just wanted to clarify there. Aaron Durbin

AD 06:36 PM coreboot Bug #166 (New): UEFI MP Services

Bug in question on Chrome OS side:
https://issuetracker.google.com/74436746 -- Yes, I know this is only viewable by Google partners. Filed March 9th.
---
While meeting w/ intel folks they really want to do MP init in FSP. I (and oth... Aaron Durbin

11/20/2017

AD 10:59 PM coreboot Bug #128 (Resolved): skylake common gpio differences on purism

Aaron Durbin

07/13/2017

AD 07:59 PM coreboot Bug #128: skylake common gpio differences on purism

deleted formatted comment now that I figured out how to edit the description. Aaron Durbin