Project

General

Profile

Actions

Bug #49

open

board_status.sh does not check git identity

Added by Daniel Kulesz about 6 years ago. Updated almost 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
infrastructure
Target version:
-
Start date:
04/30/2016
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

Running board_status.sh from live environments seems like a good idea at first sight.

However, board_status.sh does not check git identities beforehand and only prints warnings during uploading process. In fact, it fails (more or less silently) to commit the changes due to not configured git identity. Now, even if you set the git identity afterwards and re-run it, it refuses to file the board_status because it says that it's a duplicate, while in fact the previous report was not uploaded at all.

So imho we have two problems here:

  • board_status.sh does not check git identities beforehand
  • board_status reports false positives regarding duplicate status

Related issues

Blocks coreboot - Feature #210: Improve board-statusNewPatrick Georgi

Actions
Actions #1

Updated by Patrick Georgi almost 2 years ago

Actions #2

Updated by Daniel Kulesz almost 2 years ago

Thank you for coming back to this. I assume that fixing the first issue would already by sufficient to prevent the failure I originally reported for most cases.

Actions

Also available in: Atom PDF