Actions
Bug #466
closedUse printf instead of echo -n
Start date:
03/06/2023
Due date:
% Done:
0%
Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:
Description
Building flashrom on macOS, this is part of the output:
Building flashrom version v1.3.0
-n C compiler found:
Apple LLVM version 8.0.0 (clang-800.0.42.1)
This ("C compiler found:" being preceded by "-n" and followed by a newline) is happening because you are using echo -n which is not portable. Use printf instead. I refer you to cedb09de9d27d1608e02158c710dd6f2908c8ef1 where you've fixed this once before.
I attempted to follow your onerous contribution guidelines for submitting a patch and encountered errors I did not know how to correct; I won't be making any further attempts at that and hope the patch attached to this issue is sufficient.
Files
Actions