Project

General

Profile

Actions
Copy link

Bug #466

closed

Use printf instead of echo -n

Added by Ryan Schmidt over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
none
Start date:
03/06/2023
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

Building flashrom on macOS, this is part of the output:

Building flashrom version v1.3.0
-n C compiler found: 
Apple LLVM version 8.0.0 (clang-800.0.42.1)

This ("C compiler found:" being preceded by "-n" and followed by a newline) is happening because you are using echo -n which is not portable. Use printf instead. I refer you to cedb09de9d27d1608e02158c710dd6f2908c8ef1 where you've fixed this once before.

I attempted to follow your onerous contribution guidelines for submitting a patch and encountered errors I did not know how to correct; I won't be making any further attempts at that and hope the patch attached to this issue is sufficient.

Files

echo-n.patch (1.68 KB) echo-n.patch Ryan Schmidt, 03/06/2023 11:21 PM
Actions
Copy link
 #2

Updated by Anastasia Klimchuk over 1 year ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Anastasia Klimchuk over 1 year ago

  • Status changed from In Progress to Resolved

Ryan, thank you so much for reporting! Patch is merged, should be fixed in head, and will be included in 1.4.

On the separate note, I am sorry that you found contribution guidelines onerous. You are not wrong.
We are currently in the middle of an effort to re-write dev guidelines to be more clear, readable and modern. Hopefully new guidelines are better and maybe next time you will send a patch to us!

Actions
Copy link

Also available in: Atom PDF