Project

General

Profile

Actions
Copy link

Bug #432

closed

t440p reboots on suspend

Added by Josh R about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
none
Start date:
10/21/2022
Due date:
% Done:

0%

Estimated time:
Affected versions:
4.15
Needs backport to:
Affected hardware:
Lenovo ThinkPad T440p
Affected OS:
Ubuntu 22.04 (Pop OS)

Description

Per request, adding new ticket for an issue with my t440p where attempting to resume on suspend results in a reboot (or at least, not resuming from DRAM).

My t440p already has coreboot installed (via osbmk). Following instructions from issue #412, I have attempted the following:

sudo flashrom -p internal --ifd -i bios -w the_full_12MiB_osbmk.rom --noverify-all

...but that did not seem to do the trick (still "restarts" without resuming from RAM).

Note that I am using the "full" 12MB osbmk rom (not split by 4MiB and 8MiB, as that seemed intended for the hardware flashing instructions).

coreboot version looks like 4.15.204, and flashrom version 1.2-640.

If it helps, attached cbmem -1 output with a "normal boot" followed by a later resume from suspend (that resulted in a restart).

Thanks in advance. I guess you don't realize how much you use suspend until it doesn't work anymore :)

Files

Download all files
cbmem.20221019195923.normal_boot.log (36.2 KB) cbmem.20221019195923.normal_boot.log Josh R, 10/21/2022 01:06 AM
cbmem.20221019200724.from_suspend.log (36.3 KB) cbmem.20221019200724.from_suspend.log Josh R, 10/21/2022 01:06 AM
osboot_t440p_ifd_bin_is_also_borked.log (10.2 KB) osboot_t440p_ifd_bin_is_also_borked.log Angel Pons, 10/21/2022 11:56 AM

Related links

https://ticket.coreboot.org/issues/412

Actions
Copy link
 #1

Updated by Angel Pons about 2 years ago

  • Status changed from New to Response Needed
  • Affected hardware changed from Lenovo t440p to Lenovo ThinkPad T440p

Hi, osboot is not the same as coreboot. Have you asked the people responsible for osboot to provide support?

It would be great if you could test with upstream coreboot, to make sure the issue is in coreboot and not about something the osboot people did.

Actions
Copy link
 #2

Updated by Angel Pons about 2 years ago

Hmmm, looks like the issue happens because the MRC cache

Actions
Copy link
 #3

Updated by Angel Pons about 2 years ago

sigh where is the "Edit" button?

Looks like the issue happens because something is messed up with the "ROM size"...

flash size 0x2800000 bytes
SF: Detected 00 0000 with sector size 0x1000, total 0x2800000
SF size 0x2800000 does not correspond to CONFIG_ROM_SIZE 0xc00000!!

This seems like a bug in osboot.

Actions
Copy link
 #4

Updated by Angel Pons about 2 years ago

Yes, it's definitely an osboot problem... Please report the issue to osboot folks, and point them to this ticket.

After grabbing the T440p IFD.bin that osboot uses and using util/ifdtool's -d option on it (after manually padding to 12 MiB; you can just use the osboot image you built), it's clear why coreboot thinks the flash chip is much larger...

  Component 2 Density:                 32MB
  Component 1 Density:                 8MB

Component 2 Density should be "4MB" (technically, 4 MiB) instead. No clue where the IFD.bin that osboot uses comes from, but it's broken. See attached log for the complete ifdtool -d output.

Actions
Copy link
 #5

Updated by Josh R about 2 years ago

Angel Pons wrote in #note-4:

Yes, it's definitely an osboot problem... Please report the issue to osboot folks, and point them to this ticket.

After grabbing the T440p IFD.bin that osboot uses and using util/ifdtool's -d option on it (after manually padding to 12 MiB; you can just use the osboot image you built), it's clear why coreboot thinks the flash chip is much larger...

  Component 2 Density:                 32MB
  Component 1 Density:                 8MB

Component 2 Density should be "4MB" (technically, 4 MiB) instead. No clue where the IFD.bin that osboot uses comes from, but it's broken. See attached log for the complete ifdtool -d output.

I appreciate you looking into this. I have submitted an issue here: https://notabug.org/osboot/osbmk/issues/161

For what it's worth, there was some discussion here on using an extracted IFD from a Lenovo-provided archive: https://notabug.org/osboot/osbmk/issues/129

Actions
Copy link
 #6

Updated by Martin Roth almost 2 years ago

  • Status changed from Response Needed to Closed

Closing as not an issue in coreboot.

Actions
Copy link

Also available in: Atom PDF