flashrom

Had a superficial look:

• manpage: --include vs. --image
• register_include_arg(): Missing return-value checks for strdup()?

Could use more eyes.

It seems to work generally, just tested it with dummyflasher.

After looking closer at "include vs image" we have discovered:
i
The patch 23021 changed --image option into --include option, changed the handling code and manpage. --image gone, there is --include instead.
The code and manpage are handling "-i" as "--include" and manpage describes "include" as alias for "-i". So the code processing the argument and manpage are consistent with each other.

However, help message that is printed from cli_classic still mentions "image", and does not mention "include" (see cli_classic_usage()).
Also in cli_classic, an array long_options[] still mentions "image" and does not mention "include".

Summarising, what to do:

1. update the help message printed from command line, see cli_classic_usage() in cli_classic
2. update long_options[] in cli_classic.

include vs image: https://review.coreboot.org/c/flashrom/+/70003
register_include_arg: https://review.coreboot.org/c/flashrom/+/70006