Bug #35
closedcommit 85a255fb (acpi/tpm: Gracefully handle missing TPM module) breaks Windows
0%
Description
The latest git code (4351ace145c4069f9c93ca7541d6dfaf8300b53b) causes a Windows BSOD during Windows boot, and it can be solved by reverting commit 85a255fbd89aba7edea7ac1d09c39099d53f7c44.
Test system: lenovo T520
Updated by Martin Roth over 8 years ago
- Subject changed from commit 85a255fbd89aba7edea7ac1d09c39099d53f7c44 breaks Windows to commit 85a255fb (acpi/tpm: Gracefully handle missing TPM module) breaks Windows
- Assignee set to Martin Roth
The issue seems to be that the T520 is always including tpm.asl, but has CONFIG_LPC_TPM disabled by default. It looks like this ends up creating an ACPI operating region of length 0x5000, but without an offset (maybe it uses an offset of 0?)
Two solutions I see -
1) Enable TPM by default on these platforms.
2) Only include TPM.asl into ACPI if the TPM is enabled in the code.
I'll push a patch for option 2 since these aren't platforms I typically work on.
Updated by Martin Roth over 8 years ago
Patch submitted here: https://review.coreboot.org/#/c/13890/
Updated by Martin Roth over 8 years ago
- Status changed from New to Closed
commit f7fd6306 (tpm/acpi/tpm.asl: Only include tpm.asl if tpm is enabled) seems to have fixed the issue. Closing.