Add timeouts to nehalem raminit
I drafted a patch copying from EC init. Two questions:
1) timeout = 0x7ff; how much time is it? micros? millis? ... ?
2) what about the read32/write32 after the loops? In the case the ME isn't there ... have those to be skipped? (ie: return before read/write)
#3 Updated by Ani Chang about 2 years ago
Paul Menzel wrote:
Thank you for working on coreboot. In my experience, this bug tracker is not used to upload patches. Please push them to the coreboot Gerrit review instance . Even if they are not ready for merging.
Thanks!!! I hate RedMine! Once there is a code development tool there is no need of Redmine!
I just pushed my local repo to review.coreboot.org via Gerrit. But Jenkins said it doesn't buikd, and it must be wrong... on my machine it builds, and I pushed from the same repo I am building locally. Anyway, that is another story :)