Project

General

Profile

Actions

Bug #105

open

Add timeouts to nehalem raminit

Added by Ani Chang almost 7 years ago. Updated over 6 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
04/01/2017
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

I drafted a patch copying from EC init. Two questions:
1) timeout = 0x7ff; how much time is it? micros? millis? ... ?
2) what about the read32/write32 after the loops? In the case the ME isn't there ... have those to be skipped? (ie: return before read/write)

regards


Files

Actions #1

Updated by Ani Chang almost 7 years ago

Ani Chang wrote:

I drafted a patch copying from EC init.

The patch doesn't work. I tried also to skip the read32/write32 after the timeout. As well as commenting out the whole functions. Need to enable ehci debug ...

Actions #2

Updated by Paul Menzel almost 7 years ago

Thank you for working on coreboot. In my experience, this bug tracker is not used to upload patches. Please push them to the coreboot Gerrit review instance [1]. Even if they are not ready for merging.

[1] https://www.coreboot.org/Git

Actions #3

Updated by Ani Chang almost 7 years ago

Paul Menzel wrote:

Thank you for working on coreboot. In my experience, this bug tracker is not used to upload patches. Please push them to the coreboot Gerrit review instance [1]. Even if they are not ready for merging.

[1] https://www.coreboot.org/Git

Thanks!!! I hate RedMine! Once there is a code development tool there is no need of Redmine!

I just pushed my local repo to review.coreboot.org via Gerrit. But Jenkins said it doesn't buikd, and it must be wrong... on my machine it builds, and I pushed from the same repo I am building locally. Anyway, that is another story :)

Actions #4

Updated by Paul Menzel over 6 years ago

  • Subject changed from Adding timeouts to nehalem raminit to Add timeouts to nehalem raminit

Sorry for the late reply. Could you please add the URL of your change in Gerrit to this issue?

Actions

Also available in: Atom PDF