General

Profile

PM Peter Marheine

  • Login: pmarheine
  • Registered on: 05/02/2022
  • Last sign in: 07/20/2025

Issues

open closed Total
Assigned issues 1 6 7
Reported issues 0 0 0

Projects

Project Roles Registered on
flashrom Developer 05/06/2022

Activity

11/10/2024

PM 11:21 PM flashrom Feature #568: Investigate maybe we can increase minimum required meson version (revisit in 2027)
I think we need to keep 0.56 at least for now, since at least a few distributions that are still in support only have 0.56.
* Debian oldstable (Bullseye): supported until September 2026, but meson 1.0 is available as an optional back...
Peter Marheine

09/26/2024

PM 05:11 AM flashrom Bug #561: Install script can't find cmocka
`ich_descriptors_tool` isn't a subproject (it doesn't use `subproject()` or a wrap file), so it would be unaffected.
However, I didn't like how `--skip-subprojects` needs to be specified on the command line (it adds burden to users), ...
Peter Marheine
PM 04:21 AM flashrom Bug #561: Install script can't find cmocka
It seems like meson doesn't currently provide a good way to explicitly select install behavior for a subproject (which cmocka currently is, since we're using a wrap for it). From https://github.com/mesonbuild/meson/issues/10561, `meson ... Peter Marheine
PM 12:29 AM flashrom Bug #561: Install script can't find cmocka
We probably shouldn't be trying to install the tests or related libraries at all, so need to look into how to tell meson not to install chosen things. Peter Marheine

06/12/2024

PM 01:32 AM flashrom Bug #525 (Resolved): Potential clash when custom get_flash_region() called in erase_write
https://review.coreboot.org/c/flashrom/+/82393 has been merged, so we believe this bug is fixed. Peter Marheine

05/13/2024

PM 05:37 AM flashrom Bug #525: Potential clash when custom get_flash_region() called in erase_write
Combined fix with tests: https://review.coreboot.org/c/flashrom/+/82393/
The new test cases #0 and #5 both fail without the fix, because it tries to erase 8 bytes using the 16-byte erase opcode.
Peter Marheine

11/01/2023

PM 11:22 PM flashrom Bug #504 (Closed): MingW meson build is broken with pre-2019 libraries
As there have been no other opinions on whether we should try to support sufficiently old MinGW, I'm closing this since I don't think it's worth supporting. Peter Marheine

09/05/2023

PM 02:06 AM flashrom Bug #504: MingW meson build is broken with pre-2019 libraries
I meant in meson.build, but we already define a bunch of feature selection macros that should make the required features available. The problem is only that old versions of MinGW tools don't correctly handle those feature test macros to ... Peter Marheine

09/01/2023

PM 07:44 AM flashrom Bug #504: MingW meson build is broken with pre-2019 libraries
Missed a word: pre-2.12 versions of glibc require `_XOPEN_SOURCE` for `strdup`. Peter Marheine
PM 07:43 AM flashrom Bug #504: MingW meson build is broken with pre-2019 libraries
On further investigation, we already set `_POSIX_C_SOURCE=200809` which should provide `fdopen` and `fileno`, so we can put the blame for those on MinGW (which seems like it has been fixed at some point). Pre-2.12 versions of glibc requi... Peter Marheine

Also available in: Atom