Bug #67 closed
lenovo/x220: 6f11559 breaks coreboot
Added by Nicola Corna almost 9 years ago.
Updated almost 9 years ago.
Description
Starting from commit 6f1155916a8b2f5409d0992963a1c16178794a48 coreboot doesn't boot anymore on my Lenovo Thinkpad X220t.
Files
cbfs (1.89 KB)
cbfs
Nicola Corna, 08/22/2016 05:53 PM
config (19.2 KB)
config
Nicola Corna, 08/22/2016 05:53 PM
cbmem_c (70.1 KB)
cbmem_c
cbmem -c of the fallback image (built on a previous commit)
Nicola Corna, 08/22/2016 05:53 PM
dmesg (62.2 KB)
dmesg
dmesg of the fallback image (built on a previous commit)
Nicola Corna, 08/22/2016 05:53 PM
Does the following patch fix it?
diff --git a/src/drivers/spi/boot_device_rw_nommap.c b/src/drivers/spi/boot_device_rw_nommap.c
index 2a9f19f..bf15e99 100644
--- a/src/drivers/spi/boot_device_rw_nommap.c
+++ b/src/drivers/spi/boot_device_rw_nommap.c
@@ -78,6 +78,9 @@ void boot_device_init(void)
if (car_get_var(sfg) != NULL)
return;
+ /* Ensure any necessary setup is performed by the drivers. */
+ spi_init();
+
car_set_var(sfg, spi_flash_probe(bus, cs));
}
Aaron Durbin wrote:
Does the following patch fix it?
diff --git a/src/drivers/spi/boot_device_rw_nommap.c b/src/drivers/spi/boot_device_rw_nommap.c
index 2a9f19f..bf15e99 100644
--- a/src/drivers/spi/boot_device_rw_nommap.c
+++ b/src/drivers/spi/boot_device_rw_nommap.c
@@ -78,6 +78,9 @@ void boot_device_init(void)
if (car_get_var(sfg) != NULL)
return;
+ /* Ensure any necessary setup is performed by the drivers. */
+ spi_init();
+
car_set_var(sfg, spi_flash_probe(bus, cs));
}
It does, thank you
Status changed from New to Resolved
Also available in: Atom PDF