Actions
Bug #67
closedlenovo/x220: 6f11559 breaks coreboot
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
08/22/2016
Due date:
% Done:
0%
Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:
Description
Starting from commit 6f1155916a8b2f5409d0992963a1c16178794a48 coreboot doesn't boot anymore on my Lenovo Thinkpad X220t.
The LEDs turn on but the HDD LED and the screen backlight stay off, either with native gfx or vendor OpROM
COMMON_CBFS_SPI_WRAPPER is set to N
Files
Updated by Aaron Durbin over 7 years ago
Does the following patch fix it?
diff --git a/src/drivers/spi/boot_device_rw_nommap.c b/src/drivers/spi/boot_device_rw_nommap.c
index 2a9f19f..bf15e99 100644
--- a/src/drivers/spi/boot_device_rw_nommap.c
+++ b/src/drivers/spi/boot_device_rw_nommap.c
@@ -78,6 +78,9 @@ void boot_device_init(void)
if (car_get_var(sfg) != NULL)
return;
+ /* Ensure any necessary setup is performed by the drivers. */
+ spi_init();
+
car_set_var(sfg, spi_flash_probe(bus, cs));
}
Updated by Nicola Corna over 7 years ago
Aaron Durbin wrote:
Does the following patch fix it?
diff --git a/src/drivers/spi/boot_device_rw_nommap.c b/src/drivers/spi/boot_device_rw_nommap.c index 2a9f19f..bf15e99 100644 --- a/src/drivers/spi/boot_device_rw_nommap.c +++ b/src/drivers/spi/boot_device_rw_nommap.c @@ -78,6 +78,9 @@ void boot_device_init(void) if (car_get_var(sfg) != NULL) return; + /* Ensure any necessary setup is performed by the drivers. */ + spi_init(); + car_set_var(sfg, spi_flash_probe(bus, cs)); }
It does, thank you
Updated by Aaron Durbin over 7 years ago
Posted fix in https://review.coreboot.org/#/c/16297/
Actions