Project

General

Profile

Actions

Bug #617

open

Missing safeguard: CBFS_SIZE greater than BIOS region in the IFD

Added by gaspar ilom about 10 hours ago. Updated about 7 hours ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
11/14/2025
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
haswell
Affected OS:

Description

There are no effective safeguards to enforce that the CONFIG_CBFS_SIZE does not exceed the bios region as declared in the IFD.

Impact

  • Downstream under Heads with a maximized bios region for the Haswell boards (T440p and W541) we could verify that this bug leads to an overflow when training the memory cache that makes it not work. This happens both with MRC blob and NRI and causes very slow boot times (20s) and S3 suspend/resume does not work.
  • Effects on other boards have not been observed but are possible.

Expected behavior

Coreboot should not build successfully if the CBFS_SIZE exceeds the bios region in the IFD and error out reporting the problem that caused this.

Analysis

Full details are under the PR in Heads and in particular this comment by @tlaurion https://github.com/linuxboot/heads/pull/2025/#issuecomment-3524672338

Ifttool reports a bios region of 0xBDEFFF (BDEFFF).
However, the coreboot config contained:

CONFIG_CBFS_SIZE=0xBE4FFF
./build/x86/coreboot-25.09/util/ifdtool/ifdtool --platform ifd2 --layout w541_layout blobs/w541/ifd.bin && cat w541_layout 
File blobs/w541/ifd.bin is 4096 bytes
Wrote layout to w541_layout
00000000:00000fff fd
00021000:00bfffff bios
00003000:00020fff me
00001000:00002fff gbe

After fixing the CONFIG_CBFS_SIZE the issues were fixed and fast boot with trained memory cache and S3 suspen/resume work again with NRI: https://github.com/linuxboot/heads/pull/2025/commits/9b8b9cacdcea4f67c95dcec10b3153fc8c016940

Actions #1

Updated by Maximilian Brune about 7 hours ago

Does this patch detect your issue? https://review.coreboot.org/c/coreboot/+/73470

Actions

Also available in: Atom PDF