Project

General

Profile

Actions

Cleanup #480

open

amd/common/acpi/gpio_bank_lib.asl: IASL remarks: Creation of named objects within a method is highly inefficient, use globals or method local variables instead

Added by Paul Menzel about 1 year ago. Updated about 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
04/10/2023
% Done:

0%

Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

Building AMD boards using AMD common code like google/kahlee (Careena) or google/myst, IASL show the remarks below:

$ git log --oneline --no-decorate -1
f2e8865d76 soc/amd/common/blk/pcie: Program LTR max latencies
$ make menuconfig
[…]
$ make -j4
Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20200925
Copyright (c) 2000 - 2020 Intel Corporation

dsdt.asl     49:  Name(BUFF, Buffer(Local0) {})
Remark   2173 -          ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.S2BF)

dsdt.asl    117:  OperationRegion (GPDW, SystemMemory, Local0, 4)
Remark   2173 -                      ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.GPRD)

dsdt.asl    126:  OperationRegion (GPDW, SystemMemory, Local0, 4)
Remark   2173 -                      ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.GPWR)

dsdt.asl    134:  OperationRegion (GPDW, SystemMemory, GPAD (Arg0), 4)
Remark   2173 -                      ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.STXS)

dsdt.asl    143:  OperationRegion (GPDW, SystemMemory, GPAD (Arg0), 4)
Remark   2173 -                      ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.CTXS)

dsdt.asl    152:  OperationRegion (GPDW, SystemMemory, GPAD (Arg0), 4)
Remark   2173 -                      ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.GRXS)

dsdt.asl    162:  OperationRegion (GPDW, SystemMemory, GPAD (Arg0), 4)
Remark   2173 -                      ^ Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_SB.GTXS)

ASL Input:     dsdt.asl -   33891 bytes   1278 keywords    901 source lines
AML Output:    dsdt.aml -   13412 bytes    909 opcodes     369 named objects

Compilation successful. 0 Errors, 0 Warnings, 7 Remarks, 295 Optimizations, 46 Constants Folded
    IASL       3150 warning types were ignored!
    IASL       build/dsdt.aml disassembled correctly.

Moved to common in commit 251d305e73f7 (soc/amd/stoneyridge: Move GPIO support to common).

Actions #1

Updated by Martin Roth about 1 year ago

  • Tracker changed from Bug to Cleanup

As these are remarks, it would certainly be nice if they were fixed, but I can't call this a bug, even if it isn't efficient.

Changing from Bug to Cleanup. Leaving priority as normal, because I agree with Paul that this should be addressed.

Actions

Also available in: Atom PDF