Project

General

Profile

Actions
Copy link

Bug #475

closed
BX BX

mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c does not work as intended

Bug #475: mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c does not work as intended

Added by Bill XIE almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Bill XIE
Category:
board support
Target version:
main
Start date:
03/30/2023
Due date:
% Done:

100%

Estimated time:
Affected versions:
4.15, 4.16, 4.17, 4.18, 4.19, main
Needs backport to:
Affected hardware:
x200
Affected OS:

Description

Date back to coreboot 4.9, mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c calls get_blc_pwm_freq_value(NULL), making the following if condition always falling to the first, not to mention null dereference on strcmp() in get_blc_pwm_freq_value().

In order to determine the correct vbt filename at runtime, edid ascii string should be obtained first.

This issue may be distantly related to #474.

Related links

This is going to be fixed with https://review.coreboot.org/c/coreboot/+/74181 .

BX Updated by Bill XIE almost 3 years ago Actions
Copy link
 #1

  • Assignee changed from Arthur Heymans to Bill XIE
  • % Done changed from 0 to 90
  • Related links updated (diff)

BX Updated by Bill XIE almost 3 years ago Actions
Copy link
 #2

  • % Done changed from 90 to 100

MR Updated by Martin Roth almost 3 years ago Actions
Copy link
 #3

Can this be closed now?

BX Updated by Bill XIE over 2 years ago Actions
Copy link
 #4

Martin Roth wrote in #note-3:

Can this be closed now?

Sure.

MR Updated by Martin Roth over 2 years ago Actions
Copy link
 #5

  • Status changed from New to Resolved
Actions
Copy link

Also available in: PDF Atom