Project

General

Profile

Actions

Bug #475

closed

mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c does not work as intended

Added by Bill XIE about 1 year ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
board support
Target version:
Start date:
03/30/2023
Due date:
% Done:

100%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
x200
Affected OS:

Description

Date back to coreboot 4.9, mainboard_vbt_filename() in src/mainboard/lenovo/x200/blc.c calls get_blc_pwm_freq_value(NULL), making the following if condition always falling to the first, not to mention null dereference on strcmp() in get_blc_pwm_freq_value().

In order to determine the correct vbt filename at runtime, edid ascii string should be obtained first.

This issue may be distantly related to #474.


Related links

This is going to be fixed with https://review.coreboot.org/c/coreboot/+/74181 .

Actions #1

Updated by Bill XIE about 1 year ago

  • Assignee changed from Arthur Heymans to Bill XIE
  • % Done changed from 0 to 90
  • Related links updated (diff)
Actions #2

Updated by Bill XIE about 1 year ago

  • % Done changed from 90 to 100
Actions #3

Updated by Martin Roth about 1 year ago

Can this be closed now?

Actions #4

Updated by Bill XIE 11 months ago

Martin Roth wrote in #note-3:

Can this be closed now?

Sure.

Actions #5

Updated by Martin Roth 7 months ago

  • Status changed from New to Resolved
Actions

Also available in: Atom PDF