Project

General

Profile

Actions

Feature #294

open

Feature #290: Use clang-format for the entire tree

clang-format doesn't support wrapping single-statement conditional blocks in braces

Added by Patrick Georgi over 1 year ago. Updated over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
02/18/2021
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

We want to normalize our code towards using braces for code blocks even where they're not strictly necessary in the standard (e.g. if (a) b; -> if (a) { b }, with proper newlines). clang-format doesn't support changing anything about this style at this time.

Actions #1

Updated by Paul Menzel over 1 year ago

Also, in the case of https://review.coreboot.org/c/coreboot/+/50853/comment/8602e07a_f58119a3/, the braces are required by the coding style, as the other branches have braces.

Actions

Also available in: Atom PDF