Bug #19
open
Violations of Coding guidelines: All objects should have fully qualified types (unsigned int instead of unsigned)
Added by Martin Roth almost 9 years ago.
Updated almost 2 years ago.
Description
Some (most?) of these can be seen using the following command:
grep -Grin 'unsigned' | grep -v 'unsigned:space:*int|unsigned:space:*long|unsigned:space:*char|unsigned:space:*short'
Whatever redmine uses to parse text totally ate the regular expression above. I just added a lint script util/lint/lint-014-qualified-types to find these violations.
https://review.coreboot.org/14269
Some utilities and payload code still uses bare unsigned, but this is completely fixed in the coreboot src/ directory.
There are unfortunately some false positives within names and comments, so the lint test should be updated in addition to fixing the above issues.
Also available in: Atom
PDF