Project

General

Profile

Actions
Copy link

Bug #19

open

Violations of Coding guidelines: All objects should have fully qualified types (unsigned int instead of unsigned)

Added by Martin Roth almost 9 years ago. Updated almost 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
12/30/2015
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

Some (most?) of these can be seen using the following command:
grep -Grin 'unsigned' | grep -v 'unsigned:space:*int|unsigned:space:*long|unsigned:space:*char|unsigned:space:*short'

Actions
Copy link
 #1

Updated by Martin Roth over 8 years ago

Whatever redmine uses to parse text totally ate the regular expression above. I just added a lint script util/lint/lint-014-qualified-types to find these violations.

https://review.coreboot.org/14269

Actions
Copy link
 #2

Updated by Martin Roth almost 2 years ago

Some utilities and payload code still uses bare unsigned, but this is completely fixed in the coreboot src/ directory.

There are unfortunately some false positives within names and comments, so the lint test should be updated in addition to fixing the above issues.

Actions
Copy link

Also available in: Atom PDF