Actions
Bug #131
closedRenaming `__attribute__((packed))` to `__packed` broke coreinfo build
Start date:
07/17/2017
Due date:
% Done:
0%
Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:
Description
Commit 6a00113d (Rename attribute((packed)) --> __packed) [1] broke building the payload coreinfo.
Updated by Paul Menzel over 7 years ago
- Subject changed from Renaming *__attribute__((packed))` to `__packed` broke coreinfo build to Renaming `__attribute__((packed))` to `__packed` broke coreinfo build
Updated by Stefan Reinauer over 7 years ago
Do you have an error message I can look at? I just tried to reproduce the issue, and compiling coreinfo worked fine here.
Updated by Paul Menzel over 7 years ago
The error I pasted in #coreboot@irc.freenode.net is below.
/src/coreboot/payloads/coreinfo/cbfs_module.c:56:3: error: conflicting types for '__packed'
But I am unable to reproduce in a new environment building coreinfo as secondary payload either. Maybe libpayload needs to be rebuild or so?
Updated by Stefan Reinauer over 7 years ago
- Status changed from New to Resolved
Ah, yes. That is definitely the case. You will have to rebuild (or rather re-install) libpayload, or you will get the old include files from libpayload before the change.
Updated by Paul Menzel over 7 years ago
- Status changed from Resolved to Closed
Rebuilding libpayload fixed this indeed. Thank you.
Actions