Project

General

Profile

Actions
Copy link

Bug #131

closed

Renaming `__attribute__((packed))` to `__packed` broke coreinfo build

Added by Paul Menzel almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Stefan Reinauer
Category:
-
Target version:
-
Start date:
07/17/2017
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

Commit 6a00113d (Rename attribute((packed)) --> __packed) [1] broke building the payload coreinfo.

[1] https://review.coreboot.org/15921

Actions
Copy link
 #1

Updated by Paul Menzel almost 7 years ago

  • Subject changed from Renaming *__attribute__((packed))` to `__packed` broke coreinfo build to Renaming `__attribute__((packed))` to `__packed` broke coreinfo build
Actions
Copy link
 #2

Updated by Stefan Reinauer almost 7 years ago

Do you have an error message I can look at? I just tried to reproduce the issue, and compiling coreinfo worked fine here.

Actions
Copy link
 #3

Updated by Paul Menzel almost 7 years ago

The error I pasted in #coreboot@irc.freenode.net is below.

/src/coreboot/payloads/coreinfo/cbfs_module.c:56:3: error: conflicting types for '__packed'

But I am unable to reproduce in a new environment building coreinfo as secondary payload either. Maybe libpayload needs to be rebuild or so?

Actions
Copy link
 #4

Updated by Stefan Reinauer over 6 years ago

  • Status changed from New to Resolved

Ah, yes. That is definitely the case. You will have to rebuild (or rather re-install) libpayload, or you will get the old include files from libpayload before the change.

Actions
Copy link
 #5

Updated by Paul Menzel over 6 years ago

  • Status changed from Resolved to Closed

Rebuilding libpayload fixed this indeed. Thank you.

Actions
Copy link

Also available in: Atom PDF