Bug #127

intel/stargo2: Enabling time-stamp collection breaks the build

Added by Paul Menzel almost 2 years ago. Updated over 1 year ago.

Status:ClosedStart date:07/13/2017
Priority:NormalDue date:
Assignee:Martin Roth% Done:

0%

Category:board support
Target version:-

Description

Enabling time-stamp collection breaks the build for the board Intel Stargo 2 [1].

    CC         romstage/southbridge/intel/fsp_i89xx/romstage.o
src/southbridge/intel/fsp_i89xx/romstage.c: In function 'main':
src/southbridge/intel/fsp_i89xx/romstage.c:103:2: error: implicit declaration of function 'save_timestamp_to_cmos' [-Werror=implicit-function-declaration]
  save_timestamp_to_cmos(CMOS_MAIN_START_ADDR, rdtsc());
  ^~~~~~~~~~~~~~~~~~~~~~
src/southbridge/intel/fsp_i89xx/romstage.c:103:25: error: 'CMOS_MAIN_START_ADDR' undeclared (first use in this function)
  save_timestamp_to_cmos(CMOS_MAIN_START_ADDR, rdtsc());
                         ^~~~~~~~~~~~~~~~~~~~
src/southbridge/intel/fsp_i89xx/romstage.c:103:25: note: each undeclared identifier is reported only once for each function it appears in
src/southbridge/intel/fsp_i89xx/romstage.c:103:47: error: implicit declaration of function 'rdtsc' [-Werror=implicit-function-declaration]
  save_timestamp_to_cmos(CMOS_MAIN_START_ADDR, rdtsc());
                                               ^~~~~
src/southbridge/intel/fsp_i89xx/romstage.c:155:25: error: 'CMOS_PRE_INITRAM_ADDR' undeclared (first use in this function)
  save_timestamp_to_cmos(CMOS_PRE_INITRAM_ADDR, rdtsc());
                         ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Makefile:324: recipe for target '/dev/cb-build/coreboot-gerrit.0/INTEL_STARGO2/romstage/southbridge/intel/fsp_i89xx/romstage.o' failed
make[1]: *** [/dev/cb-build/coreboot-gerrit.0/INTEL_STARGO2/romstage/southbridge/intel/fsp_i89xx/romstage.o] Error 1
make[1]: Leaving directory '/home/coreboot/slave-root/workspace/coreboot-gerrit'

[1] https://review.coreboot.org/11864/

History

#1 Updated by Paul Menzel almost 2 years ago

  • Assignee set to Martin Roth
  • Status changed from New to In Progress

Martin pushed a commit for review.

#2 Updated by Paul Menzel over 1 year ago

  • Status changed from In Progress to Closed

The change was submitted to the master branch.

Also available in: Atom PDF