Bug #113

soc/intel/skylake sets P*RC registers three times

Added by Nico Huber over 2 years ago. Updated over 2 years ago.

Status:NewStart date:05/10/2017
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:chipset configuration
Target version:-

Description

PIRQ* Routing Control registers are set in these places:

  • lpc.c: from devicetree
  • bootblock/pch.c: from devicetree
  • irq.c: from constants passed to FSP

Don't know if the config has to match what FSP is told or if they overwrite each other. Doing this in the bootblock seems to be the least useful (at least if FSP can run without PIC interrupt delivery).

History

#1 Updated by Aaron Durbin over 2 years ago

Here's some more background:

https://review.coreboot.org/#/c/19244/7/src/soc/intel/skylake/bootblock/pch.c@151

"fwiw, I have no idea why we're bothering doing this configuration this early. We should remove this in a follow up patch. It seems to have come in from https://review.coreboot.org/#/c/10341/9/src/soc/intel/skylake/romstage/pch.c which in turn came from https://chromium-review.googlesource.com/c/270758/ but there's no reasoning as for why."

Also available in: Atom PDF