Project

General

Profile

Actions

Feature #403

open

Encapsulate interaction with flash access

Added by Alexander Goncharov over 2 years ago. Updated about 2 years ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
Programmer
Target version:
Start date:
07/15/2022
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

See the comment thread in the linked patch.

It's related to programmers mentioned in the parent task.

Actions #1

Updated by Alexander Goncharov over 2 years ago

The first thing that came to my mind is something like that:

static int atahpt_toggle_flash_access(struct atahpt_data *data, int toggle)
{
    uint32_t reg32 = 0;

    if (toggle) {
        data->flash_access = pci_read_long(data->dev, REG_FLASH_ACCESS);
        reg32 = BIT(BIT_FLASH_ACCESS);
    }

    reg32 |= data->flash_access;

    pci_write_long(data->dev, REG_FLASH_ACCESS, reg32);
    return 0;
}
Actions #2

Updated by Alexander Goncharov about 2 years ago

  • Parent task deleted (#389)

The parent task is completed, so delete dependency.

Actions

Also available in: Atom PDF