Project

General

Profile

Actions

Bug #179

closed

coreboot Makefile breaks when the path to the coreboot directory contains spaces

Added by Felix Held over 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
build system
Target version:
-
Start date:
11/10/2018
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:
Actions #1

Updated by HCL technologies over 4 years ago

As per our understanding this happens due to the CURDIR in the top level Makefile, which treats space as separator for words.
It reads till the first space in the directory path( First word), does not count the space and shows only the path till the space occurs.

Prior to CURDIR, PWD (used in most shell env) used instead in the Makefile, and later it was changed to CURDIR to make the build system more robust ,as it was not possible to use PWD in every environment.

Therefore, from our perspective we should provide an appropriate error message i.e "Path to the main directory cannot contain spaces" which can point the user for the exact error and stop further execution.

Please refer https://review.coreboot.org/c/coreboot/+/35434

Actions #2

Updated by HCL technologies over 4 years ago

As the possible fix/alternative has been merged as above check-in. We can now change the status of this issue as close.

Actions #3

Updated by Paul Menzel over 4 years ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF