Project

General

Profile

Actions

Bug #153

closed

Invalid pointer at error in FSP 1.1

Added by Roman Perepelitsin over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
01/11/2018
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

In file src/drivers/intel/fsp1_1/bootblock.c, function bootblock_fsp_temp_ram_init(void):

After call find_fsp function realised check (fih == NULL), but variable fih may be not NULL at error.

Solving (dummy):
((fih == NULL) || (fih <= ERROR_FSP_REV_MISMATCH))

Variable fih may be contain different error codes, that were ignored:
#define ERROR_NO_FV_SIG 1
#define ERROR_NO_FFS_GUID 2
#define ERROR_NO_INFO_HEADER 3
#define ERROR_IMAGEBASE_MISMATCH 4
#define ERROR_INFO_HEAD_SIG_MISMATCH 5
#define ERROR_FSP_SIG_MISMATCH 6
#define ERROR_FSP_REV_MISMATCH 7

I fall in this bug when try to run Skylake FSP GOLD - this version has different ImageRevision.

Actions #1

Updated by Nico Huber over 6 years ago

What version of coreboot are you using, it looks like this has already been fixed upstream half a year ago.

Actions #2

Updated by Roman Perepelitsin over 6 years ago

Nico Huber wrote:

What version of coreboot are you using, it looks like this has already been fixed upstream half a year ago.

Coreboot 4.6

Actions #3

Updated by Nico Huber over 6 years ago

  • Status changed from New to Resolved

Already fixed. If you can confirm that this is not an issue anymore with coreboot master, please close this ticket.

Actions

Also available in: Atom PDF