Project

General

Profile

Actions
Copy link

Bug #132

closed

Problem with `lint-stable` when changing mode of file

Added by Paul Menzel over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Martin Roth
Category:
-
Target version:
-
Start date:
07/24/2017
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

Running chmod +x on a file, which doesn’t have this mode before, committing this fails, with the error below.

Makefile.inc:559: recipe for target 'lint-stable' failed
make: *** [lint-stable] Error 1
ERROR: Does not appear to be a unified-diff format patch
Actions
Copy link
 #1

Updated by Martin Roth over 6 years ago

  • Assignee set to Martin Roth

I'll take a look. There aren't any files being changed, so there's no update diff for it to handle. I know this would be a problem for checkpatch, but I'm not sure which other lint tools would have the issue.

Actions
Copy link
 #2

Updated by Martin Roth over 6 years ago

  • Status changed from New to Resolved

This was actually a checkpatch error when running the pre-commit githook, but since checkpatch was erroring out, it didn't say that it was checkpatch.

Fixed with https://review.coreboot.org/20781
After the patch is committed, users will need to re-run 'make gitconfig' to get the change.

Actions
Copy link

Also available in: Atom PDF