Project

General

Profile

Actions

Bug #258

open

X200: Resume from S3 undocks and breaks USB

Added by Kevin Keijzer almost 4 years ago. Updated about 3 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
05/13/2020
Due date:
% Done:

0%

Estimated time:
Affected versions:
Needs backport to:
Affected hardware:
Affected OS:

Description

Since coreboot 4.11, resuming my X200 from S3 while docked will undock it immediately after waking up, like when the button on the side of the dock or Fn+F9 would be pressed. Because of this, all USB devices connected to the dock will stop working.

The machine has to be rebooted to get the dock working again. Physically undocking and redocking does not help.

I have tested coreboot 4.12 today, and the bug is still present. In coreboot 4.10, everything is working fine. Resuming from S3 will not undock the X200 there, and all devices keep working.

My guess is that an ACPI call is done that shouldn't be, or something related to the ACPI dock handling has been changed between coreboot 4.10 and 4.11.

Actions #1

Updated by Kevin Keijzer about 3 years ago

I did a bisect today, and I found that this commit introduced the problem:

96ae7a3a2d38b96c1dfee57fda2c2eaab7e9e762 is the first bad commit
commit 96ae7a3a2d38b96c1dfee57fda2c2eaab7e9e762
Author: Bill XIE <persmule@hardenedlinux.org>
Date:   Wed Oct 16 23:22:10 2019 +0800

    mb/lenovo/x200: Add ThinkPad X301 as a variant

    It is similar to X200s, with U-series CPU, slightly different gpio
    setup, no docking support, and no superio chip.

https://review.coreboot.org/c/coreboot/+/36093

Currently, on coreboot 4.13, re-docking the X200 is still completely broken.

Actions

Also available in: Atom PDF